-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider providing a mode to use a preinstalled (system) rust-analyzer
#128
Comments
This will still download the blob but at least it won't execute it (pending sublimelsp/LSP-rust-analyzer#128).
The reason it's not recommended is that the functionality and settings that are part of this package might not be fully compatible with your system version of rust-analyzer. At minimum it can cause warnings about settings being invalid and possibly more serious issues (in theory). That said, I'm not saying that it definitively shouldn't be supported. On your own risk. |
Perhaps, but as I said, automatically downloading and running binaries from Internet is not necessarily welcome; and in the environments it is not welcome, this (i.e. security) trumps convenience. That said, I was not aware it was not recommended. Would you accept a PR adding a |
PR is welcome as long as it's documented and makes it clear what the disadvantages are (what I've mentioned more or less). |
Currently,
LSP-rust-analyzer
automatically downloads into$HOME
and runs a binary from Internet. This is not necessarily welcome.Consider implementing a mode similar to LSP-clangd's
"binary": "system"
where LSP-rust-analyzer would invoke arust-analyzer
that is already installed elsewhere and/or available in$PATH
.The text was updated successfully, but these errors were encountered: