fix stale state or lack of updates on changing branches #2182
Conversation
| different, current_region = self._update_stored_region_async() | ||
| if not different: | ||
| return |
There was a problem hiding this comment.
As has been mentioned in some other issue, it's not really correct to return here if region didn't change as the file might still have changed (especially on file "reload"). The impact of this is very small currently though - pretty much only symbol highlights could misbehave.
|
Yes, we run into this issue when implementing inlay hints sublimelsp/LSP-typescript#91 (comment) The cause of the bug was the see gif IMO, It would be best to replace the |
Currently only symbol highlight and signature help relies on this check so it's not much of an issue. Other features don't go through that code path. |
* main: (80 commits) Perform inlay hint action on double instead of single click (#2175) support canceling pending completions request (#2177) Implement type hierarchy request (#2180) fix stale state or lack of updates on changing branches (#2182) Add timestamp and request duration in LSP logs (#2181) don't show diagnostics panel on save by default (#2179) trigger "on_server_response_async" also for "initialize" response (#2172) feat(API): allow setting additional text in permanent server status (#2173) Implement call hierarchy request (#2151) workaround for View Listeners not being attached for new transient view (#2174) Make Document Symbols behavior more consistent with built-in Goto Symbol (#2166) docs: fsautocomplete config - remove redundant argument (#2165) Allow missing window/workDoneProgress/create request from the server (#2159) Use "plaintext" language ID for plain text files (#2164) Improve type annotations (#2162) Don't use "escapeall" extension when formatting with mdpopups (#2163) Cut 1.21.0 Fix inlay hint parts wrapping into multiple lines (#2153) Ensure commands triggered from minihtml run on correct view (#2154) Add "Source Action" entry to the "Edit" main menu (#2149) ...
When file has been "reloaded" by ST due to branch change or just modified externally then the requests that normally happen on file changes didn't run. That includes code lenses, symbol highlights, color boxes, semantic tokens, document link and inlay hints. That result in lack of those features until file was modified or stale state like with those code lenses for example: