Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeActionTriggerKind enum access #2484

Merged
merged 2 commits into from
May 29, 2024

Conversation

jwortmann
Copy link
Member

A bug that was missed, resulting from importing the enum stdlib on Python 3.8 (compare #2446 (comment)).

Copy link

netlify bot commented May 28, 2024

Deploy Preview for sublime-lsp ready!

Name Link
🔨 Latest commit 5a2d6ad
🔍 Latest deploy log https://app.netlify.com/sites/sublime-lsp/deploys/66563a66b7514d00080eaf7f
😎 Deploy Preview https://deploy-preview-2484--sublime-lsp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@predragnikolic predragnikolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bug that was missed

I do not consider the current behavior a bug.

With the current main the server still receives the correct int.
Screenshot 2024-05-29 at 18 54 59

I will merge this regardless,
because this PR makes the triggerKind easer to read in the LSP log panel.

@predragnikolic predragnikolic merged commit 46171f6 into sublimelsp:main May 29, 2024
8 checks passed
@jwortmann jwortmann deleted the fix-code-action-kinds branch May 29, 2024 18:35
@jwortmann
Copy link
Member Author

You're right, technically the server communication wasn't affected by this, so maybe it's not a bug. I think I had earlier seen errors in the console about not being able to serialize the enums to JSON, but apparently it does still work and perhaps I remembered that wrong (or there was a different cause).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants