feat: add option to disable/enable diagnostics in hover

[HJX-001]

fixes issue #2381

[predragnikolic]

Hello,

The new setting should also be added to https://github.com/sublimelsp/LSP/blob/main/sublime-package.json

[predragnikolic]

LSP has goto next/previous diagnostics command:

LSP/Default.sublime-keymap

Line 147 in cd7cb68

// "command": "lsp_prev_diagnostic",

LSP/Default.sublime-keymap

Line 141 in cd7cb68

// "command": "lsp_next_diagnostic",

Currently, when we navigate to a diagnostics, the hover popup is shown with only diagnostics.

LSP/plugin/core/registry.py

Line 265 in cd7cb68

sublime.set_timeout_async(lambda: view.run_command('lsp_hover', {'only_diagnostics': True, 'point': diag_pos}), 200)

I'm on a phone now,
So I can't test this at the moment, but I assume that the diagnostics will not be show in the hover popup in that case with this PR.

I would suggest still showing the diagnostics in the hover popup
when navigating diagnostics with the two commands above.

[HJX-001]

I have near zero python experience, and I dont have much idea of this codebase. Turn down this pr if not suitable and the issue can be closed now as It is working for me at least.

[HJX-001]

Its my first pr so i m not very aware of workflow. It is requested to take over or guide me about 'suggested change'/ any other thing.

[predragnikolic]

The PR is good, just needs some additional things.

It is ok if you don't know the codebase,
And if you missed a few spots,
that's why code review exist 🙂

Fell free just to push additional commits.(There is no need to close and open a new PR)

If you have additional questions, feel free to ask.

[HJX-001]

LSP has goto next/previous diagnostics command:

LSP/Default.sublime-keymap

Line 147 in cd7cb68

// "command": "lsp_prev_diagnostic",

LSP/Default.sublime-keymap

Line 141 in cd7cb68

// "command": "lsp_next_diagnostic",

Currently, when we navigate to a diagnostics, the hover popup is shown with only diagnostics.

LSP/plugin/core/registry.py

Line 265 in cd7cb68

sublime.set_timeout_async(lambda: view.run_command('lsp_hover', {'only_diagnostics': True, 'point': diag_pos}), 200)

I'm on a phone now,
So I can't test this at the moment, but I assume that the diagnostics will not be show in the hover popup in that case with this PR.

I would suggest still showing the diagnostics in the hover popup
when navigating diagnostics with the two commands above.

I tested 'next/prev diagnostics', seems like you were right about it. It is not working. It feels intutive have this working. But on the other hand someone turning off 'diagnostics' in hover should know about it. I'll try to figure out a way for turning 'diagnostics' off for hover only, not for 'next/prev diagnostics'.

[HJX-001]

added a new commit that seems resolving 'lsp prev/next diagnostics cmd' not working and added suggested changes and added entry in 'sublime-package.json'. It is requested to review updated changes

[predragnikolic]

Looks good

[HJX-001]

looks good

[predragnikolic]

Thank you for the PR