Split test cases by architecture #305
Conversation
|
@subosito hello, will you approve this change? |
|
Hey @koji-1009, would you resolve merge conflicts please? |
|
@bartekpacia |
|
Sorry. Is there anything wrong with this PR? |
koji-1009
force-pushed
the
test/update_print_output
branch
from
6db0ba8 to
3dba341
Compare
| test_print_output: | ||
| runs-on: macos-13 | ||
| test_print_output_x64: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Does the runs-on affect if the tests will be successful or not?
There was a problem hiding this comment.
Currently, flutter for Linux is only available for x64.
https://docs.flutter.dev/release/archive
Also, the GitHub Actions ubuntu is currently only available for x64. However, in the future it will be possible to run it for arm64 as well.
Therefore, if ubuntu-latest switches to arm64, this test will fail. (Probably, we cannot get the old sdk that does not support arm64.) This setting would be as expected, since it can detect that ubuntu-latest is switching to arm64 and can reveal what features flutter-action can support.
There was a problem hiding this comment.
I see, thanks a ton for sharing this valuable context!
|
|
||
|
|
||
| test_print_output_arm64: | ||
| runs-on: macos-latest |
There was a problem hiding this comment.
Does the runs-on affect if the tests will be successful or not?
There was a problem hiding this comment.
Currently, arm64 is only available for macos.
Also, if macos-latest ever changes from arm64, you will notice the change in this setting. (I would like to believe that this is not the case.)
Since macos-latest has been updated to arm64 machines, I splited
test_print_outputbetween x64 and arm64. And flutter sdk for arm64 has been provided since v3.0.0, so checked only versions after v3.0.0.ref #303 #304