Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type): Add support for interval compound literal #44

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

anshuldata
Copy link
Contributor

@anshuldata anshuldata commented Aug 12, 2024

  • Introduced APIs to create Literal of type IntervalCompound and IntervalYearToMonth

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 90.71038% with 17 lines in your changes missing coverage. Please review.

Project coverage is 54.53%. Comparing base (597afdb) to head (7d7c57a).
Report is 1 commits behind head on main.

Files Patch % Lines
expr/interval_compound_literal.go 92.50% 6 Missing ⚠️
expr/interval_year_to_month.go 85.71% 5 Missing ⚠️
types/interval_compound_type.go 91.66% 3 Missing ⚠️
types/interval_year_month_type.go 89.28% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   53.40%   54.53%   +1.13%     
==========================================
  Files          23       27       +4     
  Lines        6179     6355     +176     
==========================================
+ Hits         3300     3466     +166     
- Misses       2687     2697      +10     
  Partials      192      192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshuldata anshuldata force-pushed the anshul/SupportIntervalType branch 3 times, most recently from bec6c37 to 0b329bb Compare August 12, 2024 09:04
expr/interval_year_to_month.go Outdated Show resolved Hide resolved
expr/interval_year_to_month.go Outdated Show resolved Hide resolved
expr/interval_year_to_month.go Outdated Show resolved Hide resolved
expr/interval_compound_literal.go Outdated Show resolved Hide resolved
expr/interval_compound_literal.go Outdated Show resolved Hide resolved
expr/interval_compound_literal.go Outdated Show resolved Hide resolved
@jacques-n jacques-n added the spec-gap Is in the Substrait specification but not implemented in substrait-go label Aug 13, 2024
expr/interval_compound_literal.go Outdated Show resolved Hide resolved
plan/relations.go Outdated Show resolved Hide resolved
expr/interval_compound_literal.go Outdated Show resolved Hide resolved
expr/interval_compound_literal.go Outdated Show resolved Hide resolved
expr/interval_year_to_month.go Outdated Show resolved Hide resolved
@anshuldata
Copy link
Contributor Author

I updated PR to do away with Option and have separate Literal Impl for IntervalDayToMonth and intervalCompound type. Kindly check @jacques-n @zeroshade

expr/interval_compound_literal.go Outdated Show resolved Hide resolved
expr/interval_compound_literal.go Outdated Show resolved Hide resolved
expr/interval_compound_literal.go Show resolved Hide resolved
expr/interval_compound_literal.go Outdated Show resolved Hide resolved
expr/interval_year_to_month.go Outdated Show resolved Hide resolved
types/interval_compound_type.go Show resolved Hide resolved
types/interval_compound_type.go Show resolved Hide resolved
types/interval_year_month_type.go Outdated Show resolved Hide resolved
types/precison_timestamp_types.go Outdated Show resolved Hide resolved
@anshuldata anshuldata force-pushed the anshul/SupportIntervalType branch 4 times, most recently from 9e5c0c4 to d0c08fc Compare August 19, 2024 07:12
@anshuldata
Copy link
Contributor Author

I have raised separate PR (#48) for proto update. Once it is merged I will rebase this PR

@anshuldata anshuldata force-pushed the anshul/SupportIntervalType branch 3 times, most recently from be83797 to 8138246 Compare August 20, 2024 04:16
@anshuldata
Copy link
Contributor Author

rebased PR. It is ready for re-review @jacques-n @zeroshade

@anshuldata
Copy link
Contributor Author

rebased it

expr/interval_compound_literal.go Outdated Show resolved Hide resolved
expr/interval_compound_literal_test.go Outdated Show resolved Hide resolved
@anshuldata
Copy link
Contributor Author

can you merge this @zeroshade, I don't have write access

@zeroshade zeroshade merged commit 58e4ba0 into substrait-io:main Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-user-input spec-gap Is in the Substrait specification but not implemented in substrait-go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants