-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(type): Add support for interval compound literal #44
feat(type): Add support for interval compound literal #44
Conversation
anshuldata
commented
Aug 12, 2024
•
edited
Loading
edited
- Introduced APIs to create Literal of type IntervalCompound and IntervalYearToMonth
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 53.40% 54.53% +1.13%
==========================================
Files 23 27 +4
Lines 6179 6355 +176
==========================================
+ Hits 3300 3466 +166
- Misses 2687 2697 +10
Partials 192 192 ☔ View full report in Codecov by Sentry. |
bec6c37
to
0b329bb
Compare
3fb386a
to
c4f507b
Compare
I updated PR to do away with Option and have separate Literal Impl for IntervalDayToMonth and intervalCompound type. Kindly check @jacques-n @zeroshade |
9e5c0c4
to
d0c08fc
Compare
I have raised separate PR (#48) for proto update. Once it is merged I will rebase this PR |
be83797
to
8138246
Compare
rebased PR. It is ready for re-review @jacques-n @zeroshade |
8138246
to
c51e490
Compare
rebased it |
can you merge this @zeroshade, I don't have write access |