-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Match method to FuncDefArgType interface #53
Conversation
anshuldata
commented
Sep 2, 2024
•
edited
Loading
edited
- Added MatchWithNullability and MatchWithoutNullability methods on FuncDefArgType interface. This method returns true if argument "t" is type compatible with this type otherwise it returns false
- These two APIs are necessary considering Match behavior will differ based on function's nullability handling (MIRROR, DECLARED_OUTPUT, DISCRETE).
- Nullability "MIRROR" and "DECLARED_OUTPUT" requires MatchWithoutNullability
- Nullability "DISCRETE" will require MatchWithNullability
- Also updated go version to 1.22 to fix golint error with reflect API TypeFor
- In follow up PR I will add Match method on FunctionVariant interface
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 54.93% 55.79% +0.86%
==========================================
Files 35 35
Lines 6697 6778 +81
==========================================
+ Hits 3679 3782 +103
+ Misses 2829 2806 -23
- Partials 189 190 +1 ☔ View full report in Codecov by Sentry. |
ea854c2
to
df7c08e
Compare
Using |
I will un-draft once #52 is merged and is rebased for this PR |
00fb6fd
to
ae11628
Compare
db675e9
to
406fd0e
Compare
…terface * Also updated go version to 1.22 to fix golint error with reflect API TypeFor
406fd0e
to
2240ec9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like it is pretty clean and simple now and all outstanding requested changes have been dealt with.
The biggest controversial thing is upgrading to go 1.22. Looked at only 1.22 and 1.23 are now supported by community so that seems fine.