chore: comment

substrait-io · Oct 4, 2024 · f4723f7 · f4723f7
1 parent 3a25e3b
commit f4723f7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/core/src/main/java/io/substrait/relation/Set.java b/core/src/main/java/io/substrait/relation/Set.java
@@ -8,7 +8,7 @@
 public abstract class Set extends AbstractRel implements HasExtension {
   public abstract Set.SetOp getSetOp();
 
-  // MINUS_MULTISET and INTERSECTION_PRIMARY are set to be removed (substrait-io/substrait/pull/708)
+  // MINUS_MULTISET and INTERSECTION_PRIMARY mappings are set to be removed due to no direct SQL mapping (substrait-io/substrait/pull/708)
   public static enum SetOp {
     UNKNOWN(SetRel.SetOp.SET_OP_UNSPECIFIED),
     MINUS_PRIMARY(SetRel.SetOp.SET_OP_MINUS_PRIMARY),

diff --git a/isthmus/src/main/java/io/substrait/isthmus/SubstraitRelNodeConverter.java b/isthmus/src/main/java/io/substrait/isthmus/SubstraitRelNodeConverter.java
@@ -211,8 +211,7 @@ public RelNode visit(Set set) throws RuntimeException {
             input -> {
               relBuilder.push(input.accept(this));
             });
-    // MINUS_MULTISET and INTERSECTION_PRIMARY are set to be removed
-    // (substrait-io/substrait/pull/708)
+    // MINUS_MULTISET and INTERSECTION_PRIMARY mappings are set to be removed due to no direct SQL mapping (substrait-io/substrait/pull/708)
     var builder =
         switch (set.getSetOp()) {
           case MINUS_PRIMARY -> relBuilder.minus(false, numInputs);

diff --git a/isthmus/src/test/java/io/substrait/isthmus/utils/SetUtils.java b/isthmus/src/test/java/io/substrait/isthmus/utils/SetUtils.java
@@ -50,7 +50,7 @@ public static String getSetQuery(Set.SetOp op, boolean multi) {
   }
 
   // Generate all combinations excluding the UNKNOWN operator
-  // MINUS_MULTISET and INTERSECTION_PRIMARY are set to be removed (substrait-io/substrait/pull/708)
+  // Note: MINUS_MULTISET and INTERSECTION_PRIMARY mappings to Calcite are set to be removed due to no direct SQL mapping (substrait-io/substrait/pull/708)
   public static Stream<Arguments> setTestConfig() {
     return Arrays.stream(Set.SetOp.values())
         .filter(