chore(bash): update script per shellcheck recs #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
gforsyth
changed the title
EpsilonPrime
approved these changes
Oct 10, 2023
EpsilonPrime
approved these changes
Oct 10, 2023
|
|
||
| VERSION=$(echo $VERSION | sed 's/v//') | ||
| VERSION=${VERSION//v/} |
There was a problem hiding this comment.
Does this add a v to the beginning or remove it?
There was a problem hiding this comment.
it removes it -- bash substitution uses a different collection of slashes as compared to sed because of course it does.
${variable//find/replace}
richtia
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Periodically I remember that
shellcheckexists. Today was one of those days and so I've made afew small syntax changes to the update script to avoid some common bashy gotchas.