Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove serde support for proto types #159

Merged
merged 4 commits into from
Mar 7, 2024
Merged

refactor!: remove serde support for proto types #159

merged 4 commits into from
Mar 7, 2024

Conversation

mbrobbel
Copy link
Member

@mbrobbel mbrobbel commented Mar 6, 2024 •
edited
Loading

  • Removes serde support for the generated proto types
  • Uses pbjson ser/de when the serde feature is enabled.
  • Removes the pbjson feature.

Closes #158.

@mbrobbel mbrobbel merged commit 72e7589 into substrait-io:main Mar 7, 2024
11 checks passed
@mbrobbel mbrobbel deleted the consolidate-serde-features branch March 7, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate ser/de related features
2 participants
@mbrobbel @EpsilonPrime