Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error detection and recovery for type pattern/derivation parser #48

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

jvanstraten
Copy link
Collaborator

  • add function to check whether a pattern can ever be evaluated, and use it in places where a pattern is used only in evaluation context
  • add function to check whether a pattern can only ever match/yield a single metatype, and use it in evaluate->match scenarios and for function arguments
  • add error diagnostics for the use of constructs that are not already in use or documented by Substrait
  • add x?y:z syntax to improve error recovery and the error message for it (even though the syntax is highly ambiguous)
  • fix data type pattern not matching correctly due to typos

…n parser

 - add function to check whether a pattern can ever be evaluated, and use it
   in places where a pattern is used only in evaluation context
 - add function to check whether a pattern can only ever match/yield a single
   metatype, and use it in evaluate->match scenarios and for function
   arguments
 - add error diagnostics for the use of constructs that are not already in
   use or documented by Substrait
 - add x?y:z syntax to improve error recovery and the error message for it
   (even though the syntax is highly ambiguous)
 - fix data type pattern not matching correctly due to typos
@jvanstraten jvanstraten merged commit f316b2d into substrait-io:main Sep 8, 2022
@jvanstraten jvanstraten deleted the type-derivation-parsing branch September 8, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant