Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make substrait repo a go module #712

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

anshuldata
Copy link
Contributor

This facilitates substrait assets use in go projects

jacques-n
jacques-n previously approved these changes Sep 27, 2024
Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Have you confirmed that you can use this in substrait-go? I believe you can do a go get against your fork+hash somehow and test.

@zeroshade
Copy link
Contributor

You can use a replace directive in the go.mod locally to point it at this branch. If you need I can provide the exact commands tomorrow via go mod edit to help out.

@anshuldata
Copy link
Contributor Author

Looks good to me. Have you confirmed that you can use this in substrait-go? I believe you can do a go get against your fork+hash somehow and test.

yes, I confirmed by creating a module which has same go.mod and core.go and accessing that referring this module in substrait-go. "go get" gets to local cache and pushes to go package repository too

Screenshot 2024-09-27 at 10 56 46 AM

@anshuldata
Copy link
Contributor Author

You can use a replace directive in the go.mod locally to point it at this branch. If you need I can provide the exact commands tomorrow via go mod edit to help out.

yes, I tested it using "replace" directive to locally point to this repo

@jacques-n
Copy link
Contributor

@zeroshade , look good to you?

zeroshade
zeroshade previously approved these changes Sep 27, 2024
Copy link
Contributor

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding a small test for this? But otherwise this seems fine to me.

It also might be worthwhile adding a package level comment and maybe a testable example showing how to use the FS?

@jacques-n
Copy link
Contributor

Comment seems useful. I'm inclined to avoid adding any tests/extra stuff here. Really figure people will primarily use via substrait-go as opposed to direct.

@anshuldata anshuldata dismissed stale reviews from zeroshade and jacques-n via ece0d33 September 30, 2024 05:49
@anshuldata
Copy link
Contributor Author

It also might be worthwhile adding a package level comment and maybe a testable example showing how to use the FS?
Added comment

I'm inclined to avoid adding any tests/extra stuff here
I have skipped adding test case

@jacques-n jacques-n merged commit 3dca9b5 into substrait-io:main Oct 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants