-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make substrait repo a go module #712
feat: make substrait repo a go module #712
Conversation
f362e3b
to
9c731a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Have you confirmed that you can use this in substrait-go? I believe you can do a go get
against your fork+hash somehow and test.
You can use a |
yes, I tested it using "replace" directive to locally point to this repo |
@zeroshade , look good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth adding a small test for this? But otherwise this seems fine to me.
It also might be worthwhile adding a package level comment and maybe a testable example showing how to use the FS?
Comment seems useful. I'm inclined to avoid adding any tests/extra stuff here. Really figure people will primarily use via substrait-go as opposed to direct. |
ece0d33
|
This facilitates substrait assets use in go projects
ece0d33
to
63b8466
Compare
This facilitates substrait assets use in go projects