Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove physical types #23

Closed
wants to merge 1 commit into from

Conversation

jacques-n
Copy link
Contributor

@jacques-n jacques-n commented Sep 10, 2021

For people who need variations, they can use user defined extension types. (Simpler is better)

This is based on this subthread


This change is Reviewable

@jacques-n jacques-n requested a review from a team September 10, 2021 16:32
@emkornfield
Copy link
Contributor

I think the issue before is two items are conflated

  1. Memory Layout - how a particular type is laid out in memory. I would guess plans can be agnostic to exact representation.
  2. Logical Encodings - On the surface I think I agree with your assertion from the thread that having this modeled is likely important.

So I think this change is fine, but we might want to revisit point #2.

@jacques-n
Copy link
Contributor Author

Abandoning. Going with #25

@jacques-n jacques-n closed this Sep 14, 2021
@jacques-n jacques-n deleted the type_variations branch September 17, 2021 20:51
rkondakov pushed a commit to rkondakov/substrait that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants