Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a try the tutorial call to action #526

Closed
wants to merge 4 commits into from

Conversation

EpsilonPrime
Copy link
Member

@EpsilonPrime EpsilonPrime commented Jul 18, 2023

This adds a "Check out the Tutorial" call to action to the Substrait front page.
The call to action can be dismissed and will not return on the same browser (the
dismissal is stored in the client's local storage). The design of the call to action
allows for multiple call to actions which are differentiated by the admonition's title
(which is not shown in the call to action behavior).

@github-actions
Copy link

ACTION NEEDED

Substrait follows the Conventional Commits
specification
for
release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been overdue in adding this review for a bit :)

I think this approach is ok. Excess JS can be hard to maintain but I understand why it is there. The call to action does it's job I believe.

I think, in general, I approve. I'm not much of a graphic design / UX expert so let's briefly ask for feedback in the community meeting and, if there is nothing significant, go ahead and merge.

@EpsilonPrime
Copy link
Member Author

Based on the discussion at the most recent Community Meeting we are inclined to modify the website to make it easier to find the content that is important than to add more elements to make it more visible. The suggested approach is to remove extraneous items so the important stuff is more clear. I'll address that in a different PR.

@EpsilonPrime EpsilonPrime deleted the trythetutorial branch September 26, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants