docs: eliminate early design phase language #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EpsilonPrime
requested review from
jacques-n,
cpcloud and
westonpace
as code owners
westonpace
reviewed
Aug 30, 2023
There was a problem hiding this comment.
This sort of PR is something that I would expect to accompany a 1.0 release. Then again, maybe that isn't a terrible idea.
However, I disagree that all of these things are complete. Table functions and embedded functions, for example, are still very much undefined.
Perhaps splitting this into a "1.0" section and a "1.1" in-progress section would be cleaner.
Something a little like this jumps to mind.
EpsilonPrime
commented
Aug 30, 2023
| | [User Defined Types](/types/type_classes#user-defined-types) | Extensions that can be defined for specific IR producers/consumers. | | ||
| | [Field References](/expressions/field_references) | Expressions to identify which portions of a record should be operated on. | | ||
| | [Scalar Functions](/expressions/scalar_functions) | Description of how functions are specified. Concepts include arguments, variadic functions, output type derivation, etc. | | ||
| | [Scalar Function List](https://github.com/substrait-io/substrait/blob/main/extensions/scalar_functions.yaml) | A list of well-known canonical functions in YAML format. | |
There was a problem hiding this comment.
https://github.com/substrait-io/substrait/tree/main/extensions will get us to the list of YAML files. The blob file listed here leads to a 404 page.
richtia
reviewed
Sep 28, 2023
richtia
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification page was originally constructed to track progress during the
design phase of the project. As the design has been completed and we're now
in the final stages of fleshing it out it's time to eliminate this language.