feat: define SetRel output nullability derivation (#558) #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
requested review from
jacques-n,
cpcloud,
westonpace and
EpsilonPrime
as code owners
|
I've attempted to clarify the language around SetRels and provide additional information around deriving nullability for the output types. |
vbarua
force-pushed
the
vbarua/558/set-rel-output-shape
branch
from
2e9f307
to
16d1518
Compare
EpsilonPrime
previously approved these changes
Jun 26, 2024
EpsilonPrime
previously approved these changes
Jun 26, 2024
westonpace
previously approved these changes
Jun 27, 2024
|
Does this mean that the union relation considers "null matches null". In other words, if I intersect Do we want to clarify that somewhere too (I think the "does NULL match NULL" question comes up in joins too but I don't remember if we clarified there or not) |
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
@westonpace it does. I added a note about this. |
EpsilonPrime
approved these changes
Jul 3, 2024
westonpace
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.