Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ALL/DISTINCT modifier for all set operation types #708

Merged
merged 9 commits into from
Sep 27, 2024
Merged

feat: add ALL/DISTINCT modifier for all set operation types #708

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cabae65
feat: add a SetMode option to the SetRel spec to allow encoding of di…
kadinrabo Sep 18, 2024
45013dc
deprecated flag
kadinrabo Sep 18, 2024
fd8c0c0
buf lint failures
kadinrabo Sep 18, 2024
d745059
comments
kadinrabo Sep 19, 2024
638aa00
separate all/distinct enum values
kadinrabo Sep 20, 2024
305b339
minus/intersect all according to sql spec
kadinrabo Sep 26, 2024
79106bf
remove SET_OP_INTERSECTION_PRIMARY_ALL
kadinrabo Sep 27, 2024
22c48f4
typos
kadinrabo Sep 27, 2024
63f5e16
example typo
kadinrabo Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions proto/substrait/algebra.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,7 @@ message SetRel {
// inputs. There must be at least two inputs.
repeated Rel inputs = 2;
SetOp op = 3;
SetMode mode = 4;
substrait.extensions.AdvancedExtension advanced_extension = 10;

enum SetOp {
Expand All @@ -336,8 +337,17 @@ message SetRel {
SET_OP_MINUS_MULTISET = 2;
SET_OP_INTERSECTION_PRIMARY = 3;
SET_OP_INTERSECTION_MULTISET = 4;
SET_OP_UNION_DISTINCT = 5;
SET_OP_UNION_ALL = 6;
// Deprecated: Use SET_OP_UNION in conjunction with the mode field
// (SET_OP_MODE_DISTINCT or SET_OP_MODE_ALL) instead.
SET_OP_UNION_DISTINCT = 5 [deprecated = true];
SET_OP_UNION_ALL = 6 [deprecated = true];
SET_OP_UNION = 7;
}

enum SetMode {
SET_MODE_UNSPECIFIED = 0;
SET_MODE_DISTINCT = 1;
SET_MODE_ALL = 2;
}
}

Expand Down
Loading