Minor expression cleanups #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacques-n
commented
Nov 25, 2021
•
jacques-n
commented
- Add java package name for all proto files
- Add an explicit CAST expression
- Update the varchar literal to specify it's length
- Move AggregateFunction, AggregationPhase and SortField out of the Expression message (top-level in expression.proto).
- Remove AggregationPhase from aggregate rel since it is specified on the individual aggregation function bindings
- Add support for a filter as part of an aggregation measure (SQL2003)
- Cleanup some markdown linebreaks
- Add ReturnProgram to derivation expression to support SSA return definition (reduce repetition)
- Add java package name for all proto files - Add an explicit CAST expression - Update the varchar literal to specify it's length - Move AggregateFunction, AggregationPhase and SortField out of the Expression message (top-level in expression.proto). - Remove AggregationPhase from aggregate rel since it is specified on the individual aggregation function bindings - Add support for a filter as part of an aggregation measure (SQL2003) - Cleanup some markdown linebreaks
jacques-n
force-pushed
the
cast_and_varchar_literal
branch
from
f6e99e8
to
2dd210f
Compare
This was referenced Nov 25, 2021
almann
added a commit
to almann/substrait
that referenced
this pull request
Jul 20, 2022
Given that the `Expression` node has an explicit `Cast` variant that was added in substrait-io#88, the `cast` function definition seems redundant.
almann
added a commit
to almann/substrait
that referenced
this pull request
Jul 20, 2022
Given that the `Expression` node has an explicit `Cast` variant that was added in substrait-io#88, the `cast` function definition (added in substrait-io#152) seems redundant. This change is technically breaking as there could be dependent plans that are modeling a `cast` via function call over the expression.
almann
added a commit
to almann/substrait
that referenced
this pull request
Jul 21, 2022
Given that the `Expression` node has an explicit `Cast` variant that was added in substrait-io#88, the `cast` function definition (added in substrait-io#152) seems redundant. BREAKING CHANGE: Existing plans that are modeling `cast` with this built-in function definition over the expression will not be valid.
jacques-n
pushed a commit
that referenced
this pull request
Jul 25, 2022
Given that the `Expression` node has an explicit `Cast` variant that was added in #88, the `cast` function definition (added in #152) seems redundant. BREAKING CHANGE: Existing plans that are modeling `cast` with the `cast` function (as opposed to the `cast` expression) will no longer be valid. All producers/consumers should use the `cast` expression type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.