Add queue cancellation on request cancellation #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for dockerhub to come back up... 
|
|
Appears to fix the original issue, cancelled requests appear to be removed from the queue immediately after cancellation: |
samos123
approved these changes
Nov 11, 2023
samos123
reviewed
Nov 12, 2023
| c := make(chan struct{}) | ||
| q.queued <- c | ||
| <-c | ||
| return func() { |
There was a problem hiding this comment.
@nstogner before the dequeue happened in the returned func, but in the new code in this PR, the dequeue happens right away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
Also started refactoring the main package into sub-pkgs.