Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests, consolidate configuration, bug fixes #191

Merged
merged 15 commits into from
Sep 8, 2024
Merged

Add integration tests, consolidate configuration, bug fixes #191

merged 15 commits into from
Sep 8, 2024

Conversation

nstogner
Copy link
Contributor

@nstogner nstogner commented Sep 7, 2024 •
edited
Loading

Fixes #193

  • Add integration tests
  • Move startup logic to new command pkg to reuse within tests
  • Consolidate flag config to config.yaml with rest of configuration
  • Add config validation

@nstogner nstogner changed the title Add integration tests & fix bugs found WIP: Add integration tests & fix bugs found Sep 7, 2024
@nstogner nstogner changed the title WIP: Add integration tests & fix bugs found WIP: Add integration tests, consolidate configuration Sep 7, 2024
@nstogner nstogner changed the title WIP: Add integration tests, consolidate configuration WIP: Add integration tests, consolidate configuration, bug fixes Sep 7, 2024
@nstogner nstogner changed the title WIP: Add integration tests, consolidate configuration, bug fixes Add integration tests, consolidate configuration, bug fixes Sep 7, 2024
@nstogner nstogner requested a review from samos123 September 7, 2024 21:34
@nstogner nstogner requested a review from samos123 September 8, 2024 16:16
@nstogner nstogner merged commit b36b48b into main Sep 8, 2024
5 checks passed
@nstogner nstogner deleted the bug-fixes-and-integration-tests branch September 8, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samos123 samos123 samos123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model fails to scale up to minReplicas after updating minReplicas on existing Model
2 participants
@nstogner @samos123