Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release helm chart on tag only #195

Merged
merged 5 commits into from
Sep 8, 2024
Merged

release helm chart on tag only #195

merged 5 commits into from
Sep 8, 2024

Conversation

samos123
Copy link
Contributor

@samos123 samos123 commented Sep 8, 2024

No description provided.

Copy link
Contributor

@nstogner nstogner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added comment about comments

- name: Configure Git Credentials
run: |
git config user.name github-actions[bot]
git config user.email 41898282+github-actions[bot]@users.noreply.github.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment as to where this email comes from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea either lol. I think I blindly copy pasted it from mkdocs example. I fixed it and it's now:

          git config user.name "$GITHUB_ACTOR"
          git config user.email "$GITHUB_ACTOR@users.noreply.github.com"

which is the same as the helm release action

@samos123 samos123 merged commit 13db6fe into main Sep 8, 2024
5 checks passed
@samos123 samos123 deleted the release-helm-on-tag branch September 8, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants