-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable autoscaling #203
Conversation
nstogner
commented
Sep 11, 2024
•
edited
Loading
edited
- Add configurable scale-down-delay, autoscaling interval & window, and target (Fixes Model expose scale down delay #202)
- Add full scale-up-to-down integration test
- Update helm chart values
- Update docs (add autoscaling docs, remove how-to info from concepts and break into separate sections)
- Remove resource-profile-override fields from Model spec
150fa43
to
d22b3df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except some minor nits and question on behavior.
Alternative:
Benefits: simple and backwards compatible. Ideally we keep things backwards compatible also so our existing tutorials and docs don't all have to get updated. |
api/v1/model_types.go
Outdated
// TargetRequests is the target number of active requests per Pod. | ||
// +kubebuilder:validation:Minimum=1 | ||
// +kubebuilder:default=100 | ||
TargetRequests int32 `json:"targetRequests"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I prefer calling it concurrentRequest
42f7d40
to
ea0b609
Compare