Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike: Add integration test #65

Closed
wants to merge 2 commits into from
Closed

Spike: Add integration test #65

wants to merge 2 commits into from

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jan 31, 2024

Some test scenarios

@alpe alpe changed the title Add integration test Spike: Add integration test Feb 5, 2024
@alpe alpe mentioned this pull request Feb 5, 2024
Merged
nstogner
nstogner reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@nstogner nstogner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitate to add these tests as I think we have coverage for all of these code paths covered with the proxy tests and the existing integration tests.

@alpe
Copy link
Contributor Author

alpe commented Feb 12, 2024

No worries. I created these tests for the middleware and used them to confirm/ showcase test scenarios. Your tests look good

@alpe alpe closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstogner nstogner nstogner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @nstogner