Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: blake2b using memory #121

Merged
merged 63 commits into from
Dec 12, 2023
Merged

feat: blake2b using memory #121

merged 63 commits into from
Dec 12, 2023

Conversation

kevjue
Copy link
Contributor

@kevjue kevjue commented Nov 8, 2023 •
edited
Loading

This PR contains a new AIR implementation of Blake2B which uses curta's memory feature. Each row will now be used for an invocation of mix (the original one had all 8 mix invocations for a mix round on one row).

In addition, it contains the following changes:

  1. Support for outputting a memory trace
  2. memory_watch instruction
  3. NOT, OR, and AND instructions for bit registers

kevjue added 30 commits November 7, 2023 18:19
@kevjue
initial commit
2c92f07
@kevjue
more changes
97bcf13
@kevjue
some fixes
00602a4
@kevjue
added logic for initial compress xors
63a25f8
@kevjue
more compilation fixes
9c72d2d
@kevjue
added in multiplicities (TODO, need to add in dummy multiplicities)
e7ddf4e
@kevjue
compilation fixes
fd3232c
@kevjue
more compilation fixes
510eb2a
@kevjue
added in missing multiplicities
73817f7
@kevjue
added builder object
f6a1504
@kevjue
added digest bits and indices
4d08eec
@kevjue
added constraints for verifying digest
f009e92
@kevjue
fixed the m time
c9fbee5
@kevjue
added in t register
d09cc3f
@kevjue
air test case
a7c6667
@kevjue
bug fixes
2bbdc0f
@kevjue
some fies
c7481b3
@kevjue
fixed v_final dummy reads
1ea352f
@kevjue
more bug fixes
a614c71
@kevjue
Merge branch 'main' into kevjue/blake2b_refactor
7210cb1
@kevjue
more bug fixes
10e15dc
@kevjue
filled up 96 rows
1feaf9e
@kevjue
fixed compress_iteration
7c575eb
@kevjue
got basic air writing working
dc07e58
@kevjue
fixes
17eb4c6
@kevjue
fixes
f5f1b65
@kevjue
filled in the dummy rows
2ba1110
@kevjue
added watch_memory instruction
9f754fb
@kevjue
got correct trace for multiple messages
9727f30
@kevjue
const memory multiplicities fixed
904ffba
@kevjue kevjue changed the title chore: blake2b refactor feat: blake2b using memory Dec 6, 2023
@kevjue kevjue marked this pull request as ready for review December 6, 2023 20:54
@kevjue kevjue merged commit c4dd8dd into main Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirhemo tamirhemo tamirhemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevjue @tamirhemo