Compile Warning: 'melatonin::internal::CachedShadows' has virtual functions but non-virtual destructor

[JelleBakker]

See title

[sudara]

What compiler is this with? (Not seeing this locally) Funny, I removed the explicit dtor because of this other warning when it was in place:

#65

[JelleBakker]

I'm building a Xcode project using Xcode 15.4 exported from a JUCE 8.0.1 projucer project, with recommended compiler flags (in macOS exporter settings) enabled. Does this answer your question?

[sudara]

Yes, thanks! We have compiler warnings on the repo, so I guess I need to go investigate why the tests didn't fail...

[JelleBakker]

@sudara adding the following code in CachedShadows makes it compile with zero warnings:

CachedShadows (const CachedShadows&) = default;
CachedShadows& operator=(const CachedShadows&) = default;
virtual ~CachedShadows() = default;

[JelleBakker]

See #74