Added compatibility with juce 8 and fixed compile warnings #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Unfortunately there's some real breakage with JUCE 8 which can be seen by bumping the tests. I've done the work over in #64 (as well as turned on warnings as errors). I'll look at merging that today and take a look at the compile warning situation. |
|
Ok, I merged the actual JUCE 8 support. Could you merge in main, try to compile and see if you still get any compile warnings? I removed the explicit dtor added by https://github.com/sudara/melatonin_blur/pull/63/files and I'm not seeing any warnings locally or on GitHub. If you are still seeing em, i'll add in the solution here instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.