Better CMake support #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Yeah, this was just like... "I can't deal with this, drawing a line here for now!" — a check for JUCE would be nice! |
|
Makes sense! Added the check now :) |
|
Thanks for this! That macos-latest is being intermittent on main as well, so I'll merge anyway. I'm sort of confused why the runs are being cancelled, but I might look into removing the benchmark stuff from the CI runs, they take much longer. |
Ok, wow.... this is new.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an answer to this warning.
For my needs it's enough to just remove the warning and add the module. I'm not sure what else could be needed?
Maybe a check for JUCE like in
melatonin_inspectorwould be nice?