WIP

sudonatalie · Jan 8, 2024 · 66e3fd8 · 66e3fd8
1 parent 1190430
commit 66e3fd8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/tools/clang/lib/Sema/SemaHLSL.cpp b/tools/clang/lib/Sema/SemaHLSL.cpp
@@ -15143,7 +15143,9 @@ void DiagnoseHullEntry(Sema &S, FunctionDecl *FD, llvm::StringRef StageName) {
   if (!Attr)
     S.Diags.Report(FD->getLocation(), diag::err_hlsl_missing_attr)
         << StageName << "patchconstantfunc";
-
+  if (!(FD->getAttr<HLSLOutputTopologyAttr>()))
+    S.Diags.Report(FD->getLocation(), diag::err_hlsl_missing_attr)
+        << StageName << "outputtopology";
   return;
 }
 

diff --git a/tools/clang/test/CodeGenSPIRV/operator.overloading.resource.type.check.hlsl b/tools/clang/test/CodeGenSPIRV/operator.overloading.resource.type.check.hlsl
@@ -11,6 +11,7 @@ struct OUTPUT
 };
 
 [outputcontrolpoints(3)]
+[outputtopology("point")]
 [patchconstantfunc("foo")]
 
 INPUT main(InputPatch<INPUT, 3> Input,

diff --git a/tools/clang/test/HLSLFileCheck/hlsl/functions/attribute/patch_constant_function_missing.hlsl b/tools/clang/test/HLSLFileCheck/hlsl/functions/attribute/patch_constant_function_missing.hlsl
@@ -14,6 +14,7 @@ float4 fooey()
 [shader("hull")]
 // CHECK: error: patch constant function 'NotFooey' must be defined
 [patchconstantfunc("NotFooey")]
+[outputtopology("point")]
 float4 main(float a : A, float b:B) : SV_TARGET
 {
   float4 f = b;