Minor shell cleanups #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some duplication, and determine the script name from $0 instead of hardcoding it.
|
thx! |
| mkdir -p $ARC_DIR/plugins | ||
| mkdir -p $ARC_DIR/jobs | ||
| mkdir -p $ARC_DIR/users | ||
| mkdir $ARC_DIR/{plugins,jobs,users} |
There was a problem hiding this comment.
@SEJeff This command is failed, because $ARC_DIR is not exists.
Please add -p
example
$ export ARC_DIR=arc_dir
$ mkdir $ARC_DIR/{plugins,jobs,users}
mkdir: arc_dir: No such file or directory
mkdir: arc_dir: No such file or directory
mkdir: arc_dir: No such file or directory
$ mkdir -p $ARC_DIR/{plugins,jobs,users}
$ ls -l
total 0
drwxr-xr-x 5 sueyoshi_go staff 170 10 31 09:55 arc_dir
$ ls -l arc_dir/
total 0
drwxr-xr-x 2 sueyoshi_go staff 68 10 31 09:55 jobs
drwxr-xr-x 2 sueyoshi_go staff 68 10 31 09:55 plugins
drwxr-xr-x 2 sueyoshi_go staff 68 10 31 09:55 usersThere was a problem hiding this comment.
Stupid me, I'll try to fix that tonight.
- exit 0 is implicit when there are no errors
- Ensure $ARC_DIR is created via mkdir -p
- Make usage stdout redirect to stderr where usage info should go
|
@sue445 Perhaps the latest update is to your liking? |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some duplication, and determine the script name from $0 instead of hardcoding it.