port to python3 #10
port to python3 #10
Conversation
There was a problem hiding this comment.
@ayushnawal I have tested this, but I guess this is not a fault of the port, but it keeps spinning / checking for clipart and the journal object save button too doesn't work. Basically, there is no functional usage of this activity. Probably something is broken after some files of sugar changed or this activity was abandoned. We will wait for @quozl 's reply. Probably we need to fix that issue before this PR gets fixed
|
@srevinsaju agreed, I was facing it too but I look back closely at the code, and there was nothing to port so I submitted the PR changing |
|
Please fix any functional problems with the activity before porting to Python 3. That's clearly written in our Python 3 Porting Guide as "Quiesce the activity source by making sure the activity works properly before porting, closing any solved issues, merging any pull requests or branches and releasing the last Python 2 version". |
Tested, not many changes required.