Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help screen #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

SohamKukreti
Copy link
Contributor

I have added a help screen to the game which explains the rules of the games and how to play it. The help screen can be opened by pressing 'h' key and can be closed by pressing 'esc' key.

If required, I can create a button instead of mapping keys to open the help screen.

Explain how to play the game through help screen, map h key to open help screen and escape key to leave help screen.
@quozl
Copy link
Contributor

quozl commented Mar 28, 2024

Branch has conflicts after previous pull requests merged. Please rebase. You can avoid that in future by providing a merged branch in advance.

A screenshot in the pull request would have been useful.

Reviewed. The help has superfluous words in vague meanings;

  • "the game consists" - wrong, the game is in the motions, not the playing board,
  • "simply click" - wrong, there's no need for the click to be simple, some people may struggle,

There are too many constants.

I suggest placing the help in a list and iterating over it.

@SohamKukreti
Copy link
Contributor Author

Thank you for the review. I'll work on the aforementioned points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants