Port to Python3

[Saumya-Mishra9129]

• Port to Python3
• Port from sgmllib
• RuntimeError: generator raised StopIteration

Done with first one but the last one is still not fixed.
@quozl @pro-panda Review.

[rhl-bthr]

Reviewed the draft, thanks

[Saumya-Mishra9129]

Getting this error after above changes.

[srevinsaju]

@Saumya-Mishra9129 try replacing all raise StopIteration to return

[chimosky]

A StopIteration exception is raised by the built-in next or an iterator's __next__ method when they're no further items produced by the iterator.

As it's coming from BeautifulSoup see #29 as fixing it might also fix this.

[srevinsaju]

A StopIteration exception is raised by the built-in next or an iterator's next method when they're no further items produced by the iterator.

There has been a new PEP regarding this after the release of Python 3.7+ afaik, it works differently from that version onwards. Python3.6 and before would not face the problem.

---

As mentioned here #29 (comment), how about depending on distro specific bs4 package?

[Saumya-Mishra9129]

As mentioned here #29 (comment), how about depending on distro specific bs4 package?

Yeah we should use distro specific package. It is most common these days and a good practice.

There has been a new PEP regarding this after the release of Python 3.7+ afaik, it works differently from that version onwards. Python3.6 and before would not face the problem.

I agree with you . Since Python 3.7, all StopIteration exceptions raised inside a generator are transformed into RuntimeError (see PEP-0479 and from StackOverflow).

[quozl]

What's the status here? It looks like work in progress, but not yet fixed a StopIteration exception yet, and the exception is a normal part of next.

[Saumya-Mishra9129]

What's the status here? It looks like work in progress, but not yet fixed a StopIteration exception yet, and the exception is a normal part of next.

Thanks for review. I am working with distro specific packages of BeautifulSoup , I haven't pushed the work here yet. I don't have any idea about how to solve StopIteration , as it is in BeautifulSoup. , so I chose to work on #33 first.

[quozl]

Thanks. BeautifulSoup is somewhat outdated, and Python 3 now has parsers onboard. Why would you continue to use BeautifulSoup?

[srevinsaju]

Yes, I agree with @quozl , python3's html.parser is promising. External dependencies always make people reluctant to use an activity. Maybe by using the built in parser, it would be very portable.

[Saumya-Mishra9129]

Thanks. BeautifulSoup is somewhat outdated, and Python 3 now has parsers onboard. Why would you continue to use BeautifulSoup?

Yes, I agree with @quozl , python3's html.parser is promising. External dependencies always make people reluctant to use an activity. Maybe by using the built in parser, it would be very portable.

I even agree with both of you. I didn't think about using built in parsers and eventually land up on solving #29 . Thanks for the suggestion. I will now move forward with built-in parsers.