Not setting the display to none on duplicating. #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context wheel does not dissapear after clicking duplicate once. It allows the user to make multiple copies effectively. Fixes sugarlabs#1984
|
@walterbender Please review |
js/block.js
Outdated
| @@ -5910,7 +5910,7 @@ function Block(protoblock, blocks, overrideName) { | |||
| that.blocks.activeBlock = thisBlock; | |||
| that.blocks.prepareStackForCopy(); | |||
| that.blocks.pasteStack(); | |||
| docById('contextWheelDiv').style.display = 'none'; | |||
| docById('contextWheelDiv').style.display = ''; | |||
There was a problem hiding this comment.
The display style should already be '' at this point. No need to set it at all.
There was a problem hiding this comment.
Please squash commits together.
|
You patch works, but there is another problem. The repeated paste places the blocks on top of the previous pastes. We need to offset them. |
|
I added a fix to the offset problem to this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context wheel remains open after pressing the duplicate button.
Fixes #1984