Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #2293 and #2288 #2294

Closed
wants to merge 3 commits into from
Closed

fix issue #2293 and #2288 #2294

wants to merge 3 commits into from

Conversation

sksum
Copy link
Member

@sksum sksum commented May 28, 2020

nx,ny not defined everytime . #2293

sksum added 2 commits May 29, 2020 02:53
nx,ny not defined everytime .
resets pastebox
@sksum
Copy link
Member Author

sksum commented May 28, 2020

multiple ctrl-v keeps on adding json to previous input
clearing pastebox will fix issue #2288

@sksum sksum changed the title fix issue #2293 fix issue #2293 and #2288 May 28, 2020
@meganindya
Copy link
Member

Pertaining to the nx, ny problem, I think we can remove the nx, ny declarations totally from the if block, and only use x2, y2. Maybe, rename those two as well. As such, they aren't getting modified, so using extra variables to do the same thing feels redundant.

@sksum
Copy link
Member Author

sksum commented May 29, 2020

Pertaining to the nx, ny problem, I think we can remove the nx, ny declarations totally from the if block, and only use x2, y2. Maybe, rename those two as well. As such, they aren't getting modified, so using extra variables to do the same thing feels redundant.

sure

@sksum
Copy link
Member Author

sksum commented May 29, 2020

I don't know if this was intentional but some other variables are not being defined as well like dxi dxf .

@meganindya
Copy link
Member

Yeah, I was working on ES6 refactoring of turtle.js last night. I had to work with the var let thing a lot. In several places, the variables are declared without even var. This was one of them.

@walterbender
Copy link
Member

Cherry-picked these commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants