Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temperament fix #2352

Merged
merged 2 commits into from
Jun 13, 2020
Merged

Temperament fix #2352

merged 2 commits into from
Jun 13, 2020

Conversation

sksum
Copy link
Member

@sksum sksum commented Jun 13, 2020

#2347
that.pause() function isn't defined inside block.js , which seemingly never gets called inside the createCache loop . I Have changed it to the delay Promise from utils.js

@sksum
setup octaveSpace
5d0299d
@sksum
use delayExecution instead of .pause()
e527a07 
that.pause() is an undefined function ,
which doesn't get executed .
@sksum sksum requested a review from walterbender June 13, 2020 23:38
@walterbender walterbender merged commit 44e41dd into sugarlabs:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterbender walterbender Awaiting requested review from walterbender

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sksum @walterbender