NewPalette

[sksum]

#2385
removed any createjs code used to make palettes.
Implemented basic drag and drop(html,vanilla js) ,updating of action/box blocks ,paletteScroll
There Is still some redundant code from the previous implementation.

[sksum]

Should we continue with this old-style palette structure, or should we explore new Ideas,
also any ideas for the placement of the search widget
@walterbender

[walterbender]

This looks great so far... Dragging from the palette works well. Can someone test on a tablet device?

[walterbender]

Let's get this set of changes landed and then we can revisit new ideas.

[vaibhavdaren]

always add new line at eof.

[vaibhavdaren]

(palDiv.children.length > 1)
format this

[sksum]

added drag and drop for touch devices.

My method for testing -- served localhost to home wifi network and used http://(Ip Address):8000 to open the same in my tablet .

[walterbender]

Check list:

• eliminate CreateJS
• replicate current functionality (palette select)
• replicate current functionality (drag new blocks)
• replicate current functionality (scroll palettes)
• check to ensure adding/removing entries works (e.g., add/remove action blocks)
• does the open palette block work?
• add search widget
• use block API for generating palette block artwork
• do the hide/show blocks blocks work?

---

• implement advanced blocks as a submenu??? (needs design)

[walterbender]

I am seeing these erroRs with the latest commits... fails to fully loD.

updating palette 
js/palette.js:485 Uncaught (in promise) TypeError: Cannot read property '_resetLayout' of undefined
    at Palettes.updatePalettes (js/palette.js:485)
    at processPluginData (js/utils/utils.js:633)
    at Activity.init (js/activity.js:5110)
    at async Activity.domReady (js/activity.js:4496)
js/palette.js:119 makeSelectorButton 0
js/palette.js:119 makeSelectorButton 1
js/palette.js:119 makeSelectorButton 2
js/palette.js:1580 Time to show the palettes.

js/activity.js:2453 Uncaught TypeError: Cannot set property 'x' of null
    at _onResize (js/activity.js:2453)
    at Activity.window.onresize (js/activity.js:2499)

[walterbender]

I my latest tests, I confirmed that the open palette block works. But the hide block doesn't hide the palette.
I needed to make this change beginning at L489

	    if (showPalette in myPalettes.dict) {
		myPalettes.dict[showPalette].hideMenu();
		myPalettes.dict[showPalette].show();
	    }

[walterbender]

The MyBlocks Palette is showing up even though I have nothing in it.

[walterbender]

Adding/removing action and box blocks works.

[walterbender]

Three design issues:

(1) the selector for which of the three palette groups should have a light blue background so that the selectors don't have a white space between them.

(2) the Palette title should have a dark blue background.

(3) the Palette should extend to the bottom of the screen.

[walterbender]

• Please add a small space above the top-most block in the palette
• Please add some indication that a palette can scroll
• Please hide the palettes when "hide blocks" is clicked

[walterbender]

• Please align the icons with the labels for the palette list

[pikurasa]

The down arrow does not disappear when I am at the bottom of the palette (any palette)

[pikurasa]

It looks like #2392 (comment) was fixed -- great!

When the palette already displays all possible blocks within the screen, the down arrow appears. This may be confusing as it seems to indicate you can scroll down for more blocks.

[pikurasa]

FYI, the images for some of the blocks in the media palette are not being displayed.

[walterbender]

Oh. I had not noticed the image problem.

[pikurasa]

Japanese is rendering a little funny as well (tested on rawgit). It looks like it is trying to render the letters top to bottom.

[walterbender]

    label.setAttribute("style","width: 10px ; height: 12px");

10px width is causing the label to wrap in Japanese

But if you increase the width, it causes the selector buttons to mis-align.