improve Search #2421
Merged
improve Search #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changes made ...
|
|
The boxes option is nice. Would be good to include the same for actions. |
if you mean the user named action , it should work for those as well .(You should see action1, action2 etc in search.) |
|
Yes. The named actions |
|
I think this is ready to merge . named actions and named boxes should show up in search . |
|
Nice to have actions in search... but, I am seeing: Uncaught TypeError: Cannot read property 'palette' of undefined
|
sksum
force-pushed
the
OptimizeSearch
branch
4 times, most recently
from
f8b795a
to
9979cb6
Compare
use complete labels as identifiers add protoblk in searchSuggestions use original protoblk and not search for it again , this allows named dos and named boxes to appear in search bug fix
|
should not show any errors now . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2420 and #2317