Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add suggested Tags when publishing #2430

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Conversation

sksum
Copy link
Member

@sksum sksum commented Jul 29, 2020

@pikurasa
Copy link
Collaborator

This cannot really be tested offline. I can create a test branch to a server if necessary or we can pull this and test on rawgit -- either way.

@sksum
Copy link
Member Author

sksum commented Jul 29, 2020

all this does is gives you some suggested tags in the tags input field.
should work with localhost.

TAGS

@walterbender
Copy link
Member

This looks good to me. But please clean up the formatting:

if (score[1] && score[2] ){

should be

if (score[1] && score[2]) {

@sksum
Copy link
Member Author

sksum commented Jul 29, 2020

also the "mouse" statistic doesn't have any associated blocks. so it remains zero always.
should I change the "art" tag to be associate with "mice" &&"pen" instead of "mouse" &&"pen" ?

@walterbender
Copy link
Member

It is mouse that should be with pen. Don't worry about mice -- that is for the ensemble palette

@walterbender walterbender merged commit d4fd9b1 into sugarlabs:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants