-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pitch slider #2493
Pitch slider #2493
Conversation
Right now there is no way of generating the pitch. Upon cursor click, a hertz block must be generated. |
This is better. A couple things:
(Also, right now, if you put a number above 700, you cannot slide around the pitch whatsoever.)
|
Do we really want it to close every time you make a note? |
made suggested changes. |
There is still something peculiar with the UX. If I use the up/down arrows, I have no way to select a pitch. |
multiple hertz blocks and the save button should work now |
This works much better. I wish that the slider were wider--using the full width (the area where the blue is). |
what browser are you testing with ? |
change slider thumb style for the pitch slider widget
I like the new design a lot better. I think the length of the note when you tick up and down should be longer (a quarter note). Right now, the pitch is so short it is hard to hear. Other than that, I think we are good! |
Yes, perfect length. Thanks! |
#2485 (comment)
@pikurasa I have added a continous tone for the slider
another suggestion:
rather than using this custom slider we could use =>