Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pitchHertz/currentPitch arg blocks #2545

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

sksum
Copy link
Member

@sksum sksum commented Aug 26, 2020

rerun flowBLock functions connected to "pitchHertz" / "currentPitch"

rerun flowBLock functions connected to "pitchHertz" / "currentPitch"
@sksum sksum requested a review from meganindya August 27, 2020 17:23
@sksum
Copy link
Member Author

sksum commented Aug 28, 2020

@meganindya should I make separate logo/singer functions for these special cases?

@meganindya
Copy link
Member

current pitch is working
pitch in hertz is still returning the previous

@walterbender
Copy link
Member

We can use pitch converter to get hertz as long as current pitch is working.

@walterbender walterbender merged commit e49bef6 into sugarlabs:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants