[3851] - Implement the functionality to send changes of add-block
#3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rlabs#3924) * fix:resolves hamburger opening(sugarlabs#3914) * fix:fixes sugarlabs#3914(suggested changes done) * adjust size of grid element repositioning when using aux toolbar --------- Co-authored-by: Walter Bender <walter@sorcero.com>
Co-authored-by: anas2357 <141234155+anas2357@users.noreply.github.com>
Bumps [braces](https://github.com/micromatch/braces) to 3.0.3 and updates ancestor dependency [gulp](https://github.com/gulpjs/gulp). These dependencies need to be updated together. Updates `braces` from 2.3.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](https://github.com/micromatch/braces/commits/3.0.3) Updates `gulp` from 4.0.2 to 5.0.0 - [Release notes](https://github.com/gulpjs/gulp/releases) - [Changelog](https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md) - [Commits](gulpjs/gulp@v4.0.2...v5.0.0) --- updated-dependencies: - dependency-name: braces dependency-type: indirect - dependency-name: gulp dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add support for cents through semi-tone transposition * add 50 cents macro * add cents example * add output frequencies * fix issue with ratio cents * add a ratio-cents example
* use processPitch for all pitch types * Add support for cents (sugarlabs#3937) * add support for cents through semi-tone transposition * add 50 cents macro * add cents example * add output frequencies * fix issue with ratio cents * add a ratio-cents example * use processPitch for all pitch types * convert freq to note before scalar step
* Update README.md * Update dockerfile
apsinghdev
changed the title
js/blocks.js
Outdated
| @@ -6525,6 +6544,10 @@ class Blocks { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if(this.activity.collaboration.hasCollaborationStarted){ | |||
There was a problem hiding this comment.
please use a space between if and (
js/blocks.js
Outdated
|
|
||
| /** Signal that a new block is created */ | ||
| if (this.activity.collaboration.hasCollaborationStarted) { | ||
| if(this.isLocalUpdate){ |
js/blocks.js
Outdated
| @@ -3066,6 +3068,14 @@ class Blocks { | |||
| this.visible = true; | |||
| }; | |||
|
|
|||
| // Emit a message when a new block is created | |||
| this.emitAddedBlock = () => { | |||
| if(this.activity.collaboration.hasCollaborationStarted){ | |||
apsinghdev
changed the title
add-block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #3851
This PR implements the functionality to send
add-new-blockchanges and apply those changes to the connected client's browsers.2024-07-16.16-55-01.mp4
Note: I have added a temporary
Collaboratebutton in the toolbar to handle the infinite emitting of the events. later on, I'll shift this button to the planet.In order to test this on your local machine,
Collaboratebutton from theToolbar