-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add More Frequent "RUN LIVE" Links to Music Blocks Programming Guide #3999
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at all of these examples, but I did look at this one. The example you generated does not match the text or illustration. Please double check these live examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @walterbender,
I checked the "RUN LIVE" link and found that I am unable to use the "Set Default Instrument" block. Whenever I select it, the block is converted to an "Unknown" block.
As for the other link, I will double-check it tomorrow and create a pull request again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also @walterbender , could you please advise on what to do about this "RUN LIVE" link? I am currently unable to use "set default instrument" block.
https://musicblocks.sugarlabs.org/index.html?id=1725869737763127&run=True
This is my first open-source contribution, so I apologize for any mistakes I may have made. I would greatly appreciate your guidance and support on this journey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. There seems to be a regression with the set default instrument block. We'll have to sort it out. Maybe leave that example out of your PR, since it is not correct? And maybe you can write up an issue on the broken block?
In general, your PR is very nice. But it is only by chance that I picked up on the errant example. In the future, it would be good to make a note of such discrepancies in your commit message or PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, once you create the issue, maybe try to fix the regression? A quick look at js/blocks/ToneBlocks.js reveals that the macro definition for setdefaultinstrument is using the wrong block name. Should be an easy fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @walterbender ,
I have raised the regression issue, but I'm unable to solve it because I can't open the Music Blocks project on my localhost. I have tried everything but it just load, and it was working two days ago, but now it's not opening. Until this problem is resolved, I don't think I'll be able to contribute to any issues other than documentation.
Screen.Recording.2024-09-12.105305.mp4
Could you please guide me on what to do to open the Music Blocks project on my localhost again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you trying from a local server or directly from index.html? Can you share any console output? Are you sure that you have the current master on your machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @walterbender , I have tried running it multiple times on my local server, and there are no errors in my console. I also tried the same setup on another laptop, and it worked, but I’m not sure why it's not working on mine.
Additionally, I have added some new links to the documentation and double-checked the other live links, so you can review it again and let me know if there are any issues with my PR this time. I have assigned the regression issue to @omsuneri due to the current problem with my laptop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try running by opening the file (index.html) directly from your browser. You should see errors in the console if it doesn't load properly. (The fact that it worked on another machine makes me think that perhaps the version you are running is not up-to-date with the master branch. What is the last commit on master you are seeing?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running the project by opening the file (index.html) directly from my browser, but I am still having the same problem. One of the main issues is that I cannot open the console while it's loading. The last commit I made on the master branch was today, with the message "Added new RUN LIVE links."