Support regions without names in Update-Snippets (Azure#15746)

Fixes: Azure#15744
suhas92 · Oct 12, 2020 · bb99786 · bb99786
1 parent 08050bd
commit bb99786
Showing 1 changed file with 20 additions and 6 deletions.
diff --git a/eng/SnippetGenerator/DirectoryProcessor.cs b/eng/SnippetGenerator/DirectoryProcessor.cs
@@ -204,11 +204,19 @@ private List<Snippet> GetSnippetsInDirectory(string baseDirectory)
             var list = new List<Snippet>();
             foreach (var file in Directory.GetFiles(baseDirectory, "*.cs", SearchOption.AllDirectories))
             {
-                var syntaxTree = CSharpSyntaxTree.ParseText(
-                    File.ReadAllText(file),
-                    new CSharpParseOptions(LanguageVersion.Preview),
-                    path: file);
-                list.AddRange(GetAllSnippets(syntaxTree));
+                try
+                {
+                    var syntaxTree = CSharpSyntaxTree.ParseText(
+                        File.ReadAllText(file),
+                        new CSharpParseOptions(LanguageVersion.Preview),
+                        path: file);
+
+                    list.AddRange(GetAllSnippets(syntaxTree));
+                }
+                catch (Exception e)
+                {
+                    throw new InvalidOperationException($"Failed to discover snippets from file {file}", e);
+                }
             }
 
             return list;
@@ -222,7 +230,13 @@ private Snippet[] GetAllSnippets(SyntaxTree syntaxTree)
 
             foreach (var region in directiveWalker.Regions)
             {
-                var syntaxTrivia = region.Item1.EndOfDirectiveToken.LeadingTrivia.First(t => t.IsKind(SyntaxKind.PreprocessingMessageTrivia));
+                var leadingTrivia = region.Item1.EndOfDirectiveToken.LeadingTrivia;
+                if (!leadingTrivia.Any())
+                {
+                    // Skip unnamed regions
+                    continue;
+                }
+                var syntaxTrivia = leadingTrivia.First(t => t.IsKind(SyntaxKind.PreprocessingMessageTrivia));
                 var fromBounds = TextSpan.FromBounds(
                     region.Item1.GetLocation().SourceSpan.End,
                     region.Item2.GetLocation().SourceSpan.Start);