fix(jest): interface and string token combination #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iddan
force-pushed
the
fix/token-reflection
branch
2 times, most recently
from
d3d761f
to
8935790
Compare
Fixed the way tokens are reflected. Now it won't assume type is defined, and will make best effort to use token or type name. Removed the duplicates check there because I was not sure what should it do (I can bring it back, just need to know how to integrate it correctly). Resolves suites-dev#25
iddan
force-pushed
the
fix/token-reflection
branch
from
8935790
to
63e009f
Compare
omermorad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the way tokens are reflected. Now it won't assume the type is defined and will make the best effort to use the token or type name. There are still scenarios that
ref -> Objectis left, that I think should throw but that's for another PR.I removed the duplicates check there because I was not sure what it should do (I can bring it back but I need to know how to integrate it correctly).
I also updated some tests and types because I had false positives during development.
Resolves #25