query Dimensions with ORCID, closes #5 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsu
requested changes
Jun 19, 2024
| dimcli.login( | ||
| os.environ.get("DIMENSIONS_API_USER"), | ||
| os.environ.get("DIMENSIONS_API_PASS"), | ||
| "https://app.dimensions.ai", |
There was a problem hiding this comment.
I think it would be helpful if we refactored this code so that the username/password are passed in from rialto_airflow.dag.update_data which gets them from airflow variables similar to how sul_pub is being handled. I can push some changes to this PR if you would like help with that.
| no_auth = not (dimensions_user and dimensions_password) | ||
|
|
||
|
|
||
| @pytest.mark.skipif(no_auth, reason="no dimensions key") |
There was a problem hiding this comment.
I have set AIRFLOW_VAR_DIMENSIONS_API_USER and AIRFLOW_VAR_DIMENSIONS_API_PASS as GitHub secrets, so they should be available to our CI test environment. They should be pulled in here and then passed into the dimensions code I think?
|
If you prefer @jacobthill we can merge this as is, and add to it going forward. I'm switching the review to Approve and leave it up to you. |
edsu
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.