Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide missing cookie_flags to google analytics #3917

Merged
merged 1 commit into from
Feb 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/javascript/analytics.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ gtag('js', new Date());

Blacklight.onLoad(function() {
// gtag set property and config
const config = {}
const config = { cookie_flags: 'SameSite=None;Secure' }
// To turn off analytics debug mode, exclude the parameter altogether (cannot just set to false)
//See https://support.google.com/analytics/answer/7201382?hl=en#zippy=%2Cgoogle-tag-websites
if (document.head.querySelector("meta[name=analytics_debug]").getAttribute('value') === "true") {
Expand Down
Loading