Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to OCLC Discovery API Citation service (from WorldCat Citation service) #4415

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

corylown
Copy link
Contributor

@corylown corylown commented Sep 6, 2024

The currently configured OCLC citation API is broken and OCLC isn't going to fix it. This adds the new OCLC Discovery Citation API and some refactoring to clarify the various citation services (EDS, MODS and now OCLC Discovery). This will turn off the "Cite" button for items that would only have an OCLC citation until the new Discovery Citation API is enabled via a config.

Related shared config PR to configure this on stage: https://github.com/sul-dlss/shared_configs/pull/2242

OCLC Discovery credentials are in vault if you want them for testing:

puppet/application/searchworks/stage/oclc-discovery-client-key 
puppet/application/searchworks/stage/oclc-discovery-client-secret 

Single Citation
Screenshot 2024-09-16 at 11 20 26 AM

Multiple Citations
Screenshot 2024-09-16 at 11 20 51 AM

Screenshot 2024-09-16 at 11 20 58 AM

@corylown corylown force-pushed the oclc-citations branch 4 times, most recently from b840381 to bfc615b Compare September 9, 2024 13:25
@corylown corylown changed the title WIP - try OCLC Discovery API Citation service Switch to OCLC Discovery API Citation service (from WorldCat Citation service) Sep 9, 2024
@corylown corylown marked this pull request as ready for review September 9, 2024 18:30
@corylown corylown force-pushed the oclc-citations branch 4 times, most recently from 2bf0101 to f8566b9 Compare September 12, 2024 15:10
@corylown corylown marked this pull request as draft September 12, 2024 19:16
@corylown corylown force-pushed the oclc-citations branch 10 times, most recently from 5dceb80 to f95f83c Compare September 16, 2024 15:46
@corylown corylown marked this pull request as ready for review September 16, 2024 17:34
Copy link
Contributor

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jcoyne jcoyne merged commit 7c9bc3d into main Sep 17, 2024
4 checks passed
@jcoyne jcoyne deleted the oclc-citations branch September 17, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants