Create a factory for a cocina object #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
factories
branch
6 times, most recently
from
3740d48
to
df0eb2f
Compare
justinlittman
approved these changes
Apr 1, 2022
| administrative: { | ||
| hasAdminPolicy: 'druid:hv992ry2431' | ||
| }) | ||
| Cocina::Models::Factories.build(:item) |
There was a problem hiding this comment.
For what it is worth, I'd suggest going with dro instead of item. It avoids the mental overhead of having to remember that an item is a DRO.
jmartin-sul
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
Per discussion on #3323 it was agreed to first make factories for cocina models. This is a minimal implementation of a factory that is useful in a test.
How was this change tested? 🤨
⚡ ⚠ If this change has cross service impact (including writing to shared file systems or interacting with other SDR APIs), run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡
⚡ ⚠ If this change updates the Argo UI, run all integration tests that use Argo and create a PR on the integration test repo to fix anything this change breaks. ⚡