Decouple the validation from the presentation of invalid fields #4577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
decouple-validation-presentation
branch
2 times, most recently
from
6df9c2f
to
94bf10c
Compare
jcoyne
changed the title
jcoyne
force-pushed
the
decouple-validation-presentation
branch
from
94bf10c
to
03b2885
Compare
justinlittman
approved these changes
Jul 31, 2024
jcoyne
force-pushed
the
decouple-validation-presentation
branch
from
03b2885
to
ca94c73
Compare
|
The validation is now running immediately on page load. This is making the required fields light up in red and the cursor is placed in the label field. Sometimes my browser is taken to the label field and sometimes (as in the recording below) it's not taken there, but the validation message still appears on the screen. Screen.Recording.2024-07-31.at.1.43.19.PM.mov |
jcoyne
force-pushed
the
decouple-validation-presentation
branch
4 times, most recently
from
344daf5
to
857835e
Compare
jcoyne
force-pushed
the
decouple-validation-presentation
branch
from
857835e
to
2c3e9e8
Compare
jcoyne
changed the title
|
Andrew approved changes on Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
We have css classes sprinkled into the validation code. We can just use the validation API instead. Doesn't depend on SASS.